Template talk:Navigation

From Outreach Wiki
Jump to: navigation, search

Localization breaks template styling?[edit]

@Kaganer, Sage (Wiki Ed), AKoval (WMF): I just noticed that the navigation styling breaks on subnav pages on the Education Portal. For example, when viewing the Newsroom page, the parent navigation tab, News, is illegible because it's white text on white background. I wonder if this change coincides with the addition of Special:MyLanguage/ which was just added for further localization by User:Kaganer. Any ideas? Do we need to update any conditional styling to match the Special:MyLanguage/ bit?

I also recently edited the template to remove some empty space that generated empty <p> and <br/> elements that were cropping up and adding unnecessary spacing, but the issue was there before my edit. Tflanagan (WMF) (talk) 17:22, 2 July 2014 (UTC)

Based on some basic debugging in Chrome, it looks like the inline CSS background color value has an extra space in it, which returns an invalid color (should be #D0D0D0). The logic is still working since it produces the blue underline effect. Tflanagan (WMF) (talk) 18:26, 2 July 2014 (UTC)
More specifically, the inline CSS style reads "background: #D0D0D0&nbsp;;" -- how do we remove the trailing hardcoded non-breaking space "&nbsp;"?Tflanagan (WMF) (talk) 18:35, 2 July 2014 (UTC)
Fixed it! I moved the semicolin before the logic expression for the underline effect. Looks like it works on the portal -- hope it doens't break anything elsewhere. Sorry to blame the localization efforts… not sure why this bug cropped up!Tflanagan (WMF) (talk) 18:49, 2 July 2014 (UTC)
Yay, Tighe! That's fantastic! Thanks for debugging that and for updating us! :) Anna Koval (WMF) (talk) 19:22, 2 July 2014 (UTC)